tests: fix sql_alchemy_db fixture for timescale#1177
Conversation
there's a deadlock error that happens where the timescale background worker is running background jobs and we're altering the schema of the tables on which it's running the background job on, so we stop the background worker momentarily to allow the migrations to run.
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 453 453
Lines 37117 37125 +8
=======================================
+ Hits 36273 36281 +8
Misses 844 844
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
so this is the source of flakyness in CI?
imo this is the source of flakiness. i'm not sure why we haven't run into this on prod yet, probably because the background worker on prod doesn't run jobs as often, but i don't see why that same deadlock failure wouldn't be possible to run into on prod |
2 participants
there's a deadlock error that happens where the timescale background worker is running background jobs and we're altering the schema of the tables on which it's running the background job on, so we stop the background worker momentarily to allow the migrations to run.